Update ssh_autodetect.py to support h3c device auto detect. #3397
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I used the autodetect method on H3C devices, the return was empty, so I added H3C related content to SSH_MAPPER_DICT
ktbyers
reviewed
Mar 11, 2024
| @@ -166,6 +166,12 @@ | |||
| "priority": 99, | |||
| "dispatch": "_autodetect_std", | |||
| }, | |||
| "h3c": { | |||
There was a problem hiding this comment.
There is no h3c device_type in Netmiko.
This probably should return hp_compware or we should just put in another key to the ssh_dispatcher.py mapping h3c_compware to the HPComwareSSH class.
We should probably do the latter.
Do you want to implement that fix? If not, I will update this PR and implement it (just let me know).
add h3c mapping to HPComwareSSH.
|
I have added h3c mapping according to your requirements. If I later discover that h3c no longer works through hp_comware, I will create and write the H3CComwareSSH class. I hope to get your consent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I used the autodetect method on H3C devices, the return was empty, so I added H3C related content to SSH_MAPPER_DICT